https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330
Tomás Cohen Arazi <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #40 from Tomás Cohen Arazi <[email protected]> --- (In reply to Josef Moravec from comment #39) > (In reply to Tomás Cohen Arazi from comment #36) > > Lari, I don't think we should have such a 'validate' method. We should look > > at Jonathan's code to move C4::Members methods into Koha::Patron(s) and have > > them raise those exceptions, and build the endpoint on top of those. > > Please contact him if you are willing to help him and make this happen. > > Marking this as blocked because bug 16846 I didn't say this bug should depend on the C4::Members removal. I'm just saying that the natural way is to have the relevant methods in Koha::Patrons raise the obvious exceptions and capture them. I am all for having an API regardless of how our classes implement stuff inside, otherwise we would be stuck. But a lot of work has been done to make the codebase more coherent (in out current standards), and a lot of it is waiting for people's feedback and QA. I think it is worth mentioning, because it would mean less work on this complicated-to-implement endpoints; as Lari mentions, all the preferences that come into play are really annoying, and we need a place to put all that together and properly test. Jonathan's work on the methods mo to Koha:: namespace is a good starting point. About the validate method: I'd override ->store() and perform the validation there (so no need to call it explicitly). Look at bug 17828 for an example of that. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
