https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314
Aleisha Amohia <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Status|Needs Signoff |Failed QA --- Comment #10 from Aleisha Amohia <[email protected]> --- Hi, patch and db update apply cleanly. I see no change in behaviour in staff client nor opac side. I set the FailedLoginAttempts to 3, but I was able to attempt logging in with the wrong password unlimited times. Also, tests fail: # Subtest: update_password 1..7 ok 1 - Koha::Patron->update_password should warn if the userid is already used by another patron ok 2 - Koha::Patron->update_password should not have updated the userid ok 3 - Koha::Patron->update_password should not have updated the userid # Looks like you planned 7 tests but ran 3. not ok 8 - update_password # Failed test 'update_password' # at t/db_dependent/Koha/Patrons.t line 183. The method update is not covered by tests!# Looks like your test exited with 255 just after 8. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 15/22 subtests Test Summary Report ------------------- t/db_dependent/Koha/Patrons.t (Wstat: 65280 Tests: 8 Failed: 1) Failed test: 8 Non-zero exit status: 255 Parse errors: Bad plan. You planned 22 tests but ran 8. Files=1, Tests=8, 3 wallclock secs ( 0.03 usr 0.01 sys + 1.28 cusr 0.10 csys = 1.42 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
