https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855
Alex Buckley <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #179 from Alex Buckley <[email protected]> --- In the 'Bug 17855 - Followup patch following requests in comments 176 and 177' patch I have addressed all issues brought up in comments 176 and 177, see below: 1. Removed the <button> tag from all installer/*.tt files 2. I cannot remember the rationale for the change of the wording from 'update your database' so I have changed it back to 'Update your database'. Note: I have made only the first letter capitalised thus meeting coding guidelines. 3. I have changed 'Install Basic Configuration Settings' to 'Install basic configuration settings' so it meets the coding guidelines 4. In onboarding/onboardingstep5.tt I have removed max="10" limit on input boxes 5. I have written in default values for checkouts, loan, renewals and renewal period based on the values in the example circulation rule in the Koha 16.11 manual 6. Implemented min="0" attribute for months in "Create a new patron category" step 7. Implemented the "Continue to log in to Koha" link (which works successfully) if the install.pl is run after installation has been completed 8. I have checked and I can confirm that $step variable is an integer 9. I have set the $enrolementperioddate variable as a DateTime object, see below code snippet. I tried removing the dateformat field altogether however that made the enrolementperioddate field empty. 187 #Converts the string into a date format 188 if ($enrolmentperioddate) { 189 $enrolmentperioddate = output_pref( 190 { 191 dt => dt_from_string($enrolmentperioddate), 192 dateformat => 'DateTime', 193 dateonly => 1, 194 } 195 ); 196 } -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
