https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18367
Owen Leonard <oleon...@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleon...@myacpl.org> --- I think this isn't the right way to format the string. As it is now, the po file for this string looks like this: "No item found with barcode %s" After this patch, it looks like this: "No item found %swith barcode %s%s" I think the latter is going to be more confusing to translators. It's more verbose, but I wonder if this would be better: [% IF ERROR_ITEM_NOT_FOUND %] [% IF UNKNOWN_BARCODE %] <div class="dialog alert">No item found with barcode [% UNKNOWN_BARCODE %]</div> [% ELSE %] <div class="dialog alert">No item found</div> [% END %] [% END %] -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/