https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18462
--- Comment #13 from Alex Buckley <[email protected]> --- Created attachment 62684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62684&action=edit Bug 17855 - Reverted back to original step 3 in the web installer so there is no basic and advanced setup mode and consequently no need for SQL files to be moved to a 'default' directory for all languages. Onboarding tool and the rest of the web installer still exists in this commit How I tested in my VM (Current master): - Dropped database - Recreated database - Went through installer - Language en, Marc21 - Installed mandatory data only - Went through Onboarding tool - After finishing, logged in as superlibrarian that was created by onboarding tool Everything worked fine. Signed-off-by: Marc Véron <[email protected]> Signed-off-by: Jonathan Druart <[email protected]> Bug 17855 - Followup patch following requests in comments 176 and 177 Signed-off-by: Marc Véron <[email protected]> Signed-off-by: Jonathan Druart <[email protected]> Bug 17855: perltidy onboarding.pl Signed-off-by: Alex Buckley <[email protected]> Signed-off-by: Jonathan Druart <[email protected]> Bug 17855: Do not create a new dbh, get it from C4::Context->dbh Signed-off-by: Alex Buckley <[email protected]> Signed-off-by: Jonathan Druart <[email protected]> Bug 17855: Redirect to the installer if installation process is not done yet Signed-off-by: Alex Buckley <[email protected]> Signed-off-by: Jonathan Druart <[email protected]> Bug 17855: No need to resend the library list to the template This has been done at the beginning of the script Signed-off-by: Alex Buckley <[email protected]> Signed-off-by: Jonathan Druart <[email protected]> Bug 17855: Simplify the onboarding tool This patch should not modify a lot the behaviours of the onboarding tool. Its goal is mainly to remove duplicated as well as useless (because copy/pasted from existing script files) code. It assumes that the onboarding tool will be done on an empty database and will skip steps that are not needed. For instance if a library already exists, the first step will be skipped. One of the main problem was the lack of feedback messages sent to the user when something wrong/ok happened. Explanation on main changes: 1. Use checkauth first, then get_template_and_user => As we do not know the template to use, it's better to use checkauth first to know if the user is logged in, then retrieve the template we need, depending on the success or the failure of the action 2. Create a @messages variables Pushing messages to this variable and handling the messages via an include files (onboarding_messages.inc) simplify error handling. Note that we could remove this include file if we merge all the onboardingstepX.tt files altogether 3. Simplify creation of the admnistrator user This patch removes some unecessary checks done on the user's info (passwd to short, mandatory fields Todo (minor): Add style to feedback messages Signed-off-by: Alex Buckley <[email protected]> Signed-off-by: Jonathan Druart <[email protected]> Bug 17942 - Update style of the web installer with Bootstrap 3 This patch makes style and markup changes to the web installer and new onboarding tool (Bug 17855). - Markup has been corrected, improved, and in many places reindented. - Some page titles have been made more specific. - Some JavaScript and CSS have been moved to separate files. In the onboarding tool I have removed form validation from the markup and JavaScript in many cases where the requirements were not matched elsewhere in Koha. For instance, we shouldn't limit item type descriptions to only letters because the database doesn't require such a limit. To test, apply the patch and run the web installer with an empty database. Confirm that the installation process completes correctly and that each page looks good and works correctly. Signed-off-by: Josef Moravec <[email protected]> Signed-off-by: Liz Rea <[email protected]> https://bugs.koha-community.org/show_bug.cgi?id=18462 Bug 17942 - Add anti-clickjack code to installer doc head close -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
