https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461
Nick Clemens <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #76 from Nick Clemens <[email protected]> --- a/clubs/clubs-add-modify.pl 47 my $stored = $cgi->param('name') ? $id ? 'updated' : 'stored' : undef; *This is confusing a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt 85 This item is on hold for another borrower. *Should be patron Koha/Template/Plugin/AuthorisedValues.pm 38 my ( $self, $category, $selected, $opac ) = @_; 39 return GetAuthorisedValues( $category, $selected, $opac ); *I think this is rebase error, no 'selected' param now koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt: [% IF borrower.get_club_enrollments_count.size || borrower.get_enrollable_clubs(1).size %] *causes error - The method size is not covered by tests *same as above in: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/clubs-tab.tt * borrower.FirstValidEmailAddress is not covered by tests, I think you mean borrower.first_valid_email_address When viewing tools/clubs.pl 1 - The 'New club' button has an empty dropdown until a template is defined, it should be disabled 2 - Once the first template is defined the Clubs table says: " No club templates defined. " - should say "No clubs defined" 3 - Dates for clubs should show in clubs table When adding patrons to clubs - 1 - If no fields are associated with a club you click 'Enroll' then have a new screen with no additional info and must click 'Enroll' again - should be clearer 'Finish enrollment' or something 2 - You should not be able to add a patron to club that is out of date, or they should be hidden by default The feature adds valuable info for reporting, but I think it should have at least one default view, a link from the clubs table to "See patrons enrolled in this club" That link should be copied on the patrons club enrollement tab -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
