https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18472

--- Comment #10 from M. Tompsett <[email protected]> ---
Comment on attachment 62866
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62866
Bug 18472: Add system preferences to manage online help system

Review of attachment 62866:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18472&attachment=62866)
-----------------------------------------------------------------

::: installer/data/mysql/sysprefs.sql
@@ +115,5 @@
>  ('CronjobLog','0',NULL,'If ON, log information from cron jobs.','YesNo'),
>  ('CumulativeRestrictionPeriods',0,NULL,'Cumulate the restriction periods 
> instead of keeping the highest','YesNo'),
>  ('CurrencyFormat','US','US|FR|CH','Determines the display format of 
> currencies. eg: \'36000\' is displayed as \'360 000,00\'  in \'FR\' or 
> \'360,000.00\'  in \'US\'.','Choice'),
> +('HelpSystem', 'filebased', 'filebased', 'Select online help system.', 
> 'multiple'),
> +("INSERT IGNORE INTO systempreferences (`variable`, `value`, `options`, 
> `explanation`, `type`) VALUES  ('EnableEditingFilebasedHelp', '1', '', 
> 'Enable editing of file based Koha help.', 'yesno')" ),

This line is wrong. Looks like a cut and paste which didn't get tweaked
properly. A fresh install will fail.

::: koha-tmpl/intranet-tmpl/prog/en/includes/help-top.inc
@@ +1,1 @@
> +[% USE Koha %]

doc-head-open.inc has a [% USE Koha %] -- Is this necessary or preferred?

::: koha-tmpl/intranet-tmpl/prog/en/modules/help/mainpage.tt
@@ +1,1 @@
> +[% USE Koha %]

help-top.inc includes doc-head-open.inc which has a [% USE Koha %] -- Is this
necessary or preferred?

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to