https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063
--- Comment #74 from Marcel de Rooy <[email protected]> --- (In reply to Alex Arnaud from comment #72) > (In reply to Marcel de Rooy from comment #71) > > The situation I described is independent of this pref. You could use the > > cron job to remove expired reserves based on expiration dates entered by > > patrons. > > > > Difficult to decide the issue. The behavior of sub CancelExpiredReserves was > before: > - Cancel holds with an expiration date (asked by the patron afaik), > - Cancel other exipred holds only if ExpireReservesMaxPickUpDelay is set > to allow > > So now we have all waiting reerves with an expiration date, we can't make > the difference between those with expiration ask by the patron and those > with expiration calculated. True, but not in all cases. If you disabled ExpireReservesMaxPickUpDelay, all expired reserves must be 'patron-originated'. But the question is: do we still need to make a distinction? The reserve has expired for some reason, we can cancel it. We can just remove the line imo. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
