https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944
--- Comment #45 from Jonathan Druart <[email protected]> --- Alex, great! The patch is much better :) Indeed the return value of can_be_deleted should be 1 or 0. You can achieve that with: return $nb_items + $nb_biblioitems == 0 ? 1 : 0; You will avoid the empty string return value. In the tests: The last test says 'An item type that is used by a biblioitem cannot be deleted'. But actually you are testing that "an item that is used by AN item AND A biblioitem cannot be deleted'. You should delete the item to make it test what you want to test. Finally you will need to update the admin script. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
