https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18231
--- Comment #18 from M. Tompsett <[email protected]> --- Comment on attachment 61219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61219 Bug 18231: Make sure we will not add the column twice Review of attachment 61219: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18231&attachment=61219) ----------------------------------------------------------------- I was just expecting the .perl and removal of the .sql when I went to eyeball this. ::: Koha/Schema/Result/BorrowerAttributeType.pm @@ +154,5 @@ > ); > > > +# Created by DBIx::Class::Schema::Loader v0.07042 @ 2017-03-17 11:43:14 > +# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:0jCQN4xSJYbQC5e7fGn5WQ Why add this? ::: Koha/Schema/Result/Issue.pm @@ +222,5 @@ > ); > > > +# Created by DBIx::Class::Schema::Loader v0.07042 @ 2017-03-17 11:43:14 > +# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:zGLKwoUmq4pcvY16ei3VPg Why add this? ::: Koha/Schema/Result/Issuingrule.pm @@ +330,5 @@ > ); > > > +# Created by DBIx::Class::Schema::Loader v0.07042 @ 2017-03-17 11:43:14 > +# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:3K9yYzzg9IYRAuxSXd7CPg Why add this? ::: Koha/Schema/Result/OldIssue.pm @@ +207,5 @@ > ); > > > +# Created by DBIx::Class::Schema::Loader v0.07042 @ 2017-03-17 11:43:14 > +# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:yTyCAau9EZHBgdqN4Ptljg Why add this? ::: Koha/Schema/Result/SearchField.pm @@ +48,4 @@ > =head2 type > > data_type: 'enum' > + extra: {list => ["","string","date","number","boolean","sum"]} Is this from another bug? @@ +65,4 @@ > "type", > { > data_type => "enum", > + extra => { list => ["", "string", "date", "number", "boolean", "sum"] }, Is this from another bug? I think it may be valid, but I don't think this bug originally added it. ::: installer/data/mysql/atomicupdate/Bug-18231-id_to_ussingrules_table.perl @@ +1,3 @@ > +$DBversion = 'XXX'; # will be replaced by the RM > +if( CheckVersion( $DBversion ) ) { > + unless ( column_exists( 'issuingrules', 'issuingrules_id' ) ) { This column_exists() has been a fantastic add, since it was put in. :) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
