https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18667
Owen Leonard <oleon...@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63708|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleon...@myacpl.org> --- Created attachment 63712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63712&action=edit Bug 18667 [Revised] Show a diff view of SQL reports when converting This patch reformats the SQL conversion before-and-after view so that it shows a diff between the two, just as the Manage MARC Import interface does. This patch also makes a correction to the JavaScript which is triggered by the closing of the modal. In Bootstrap 3 "hidden.bs.modal" is the event name instead of "hidden." To test, apply the patch and find an SQL report in your reports library which requires updating. - Click the "Update SQL" button. - In the modal window, the "existing" and "updated" SQL should be shown side-by-side with colored highlighting of the differece. - Confirm that the "Update" button still works correctly. - Also confirm that if you open the preview of another report, the "Close" button hides the modal and updates the contents of the modal markup. Use your browser's DOM inspector to confirm that <div class="modal-body"> contains only <div id="loading"> and its contents. Revision moves inline style attributes to CSS block. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/