https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18279
Marcel de Rooy <m.de.r...@rijksmuseum.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.r...@rijksmuseum.nl
--- Comment #7 from Marcel de Rooy <m.de.r...@rijksmuseum.nl> ---
QA Comment:
Looks good to me.
In the lost script, this construction is little bit strange:
my $loststatusfilter = $params->{'loststatusfilter'} || undef;
Normally you would expect something as:
my $loststatusfilter = $params->{'loststatusfilter'} // '';
In this particular case, it might have a weird side effect. If you add a LOST
status for value 0 in auth values, and you select that lost value on the report
form, it will return you the lost items instead of the items with value 0.
But adding a LOST auth value for 0 is not really useful. Selecting the not lost
items on the lost form makes no sense too.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
