https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18697
Josef Moravec <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63867|0 |1 is obsolete| | Attachment #63868|0 |1 is obsolete| | Attachment #63869|0 |1 is obsolete| | Attachment #63870|0 |1 is obsolete| | Attachment #63871|0 |1 is obsolete| | --- Comment #9 from Josef Moravec <[email protected]> --- Created attachment 64025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64025&action=edit [SIGNED-OFF] Bug 18697: Fix date calculations for weekly frequencies in Serials Same solution applied as in bug 18356/18607. Consistency++ The code in _get_next_date_week is again very similar to the code in _get_next_date_month or _get_next_date_year. I will not merge them here, but we could consider that in the future. Code in GetFictiveIssueNo has been adjusted similarly to month and year. Test plan: [1] Do not apply this patch. Create a subscription for 3/week. When the first issue date is on a Saturday or Sunday, the intervals in the prediction pattern are 0,0,7,0,0,7,etc. Starting on Wed-Fri 1,1,5,etc. Starting on Mon-Tue 2,2,3,etc. [2] Apply this patch. Check again. The interval should be always 2,2,3 now and no longer depend on the day_of_week of first issue date. [3] Check another weekly frequency with multiple units per issue. Say 1 issue/3 weeks. Signed-off-by: Marcel de Rooy <[email protected]> Signed-off-by: Josef Moravec <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
