https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18753
M. Tompsett <mtomp...@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64090|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtomp...@hotmail.com> --- Created attachment 64093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64093&action=edit Bug 18753 - t/00-testcritic fails Perl::Critic Bug Description: When performing a unit test on t/00-testcritic.t with the command 'prove t/00-testcritic.t' test 221 fails Perl::Critic with not ok 221 - Test::Perl::Critic for "reserve/request.pl" Failed test 'Test::Perl::Critic for "reserve/request.pl"' at /usr/share/perl5/Test/Perl/Critic.pm line 110. Perl::Critic found these violations in "reserve/request.pl": "$itemnumbers_of_biblioitem" is declared but not used at line 314, column 5. Unused variables clutter code and make it harder to read (Severity: 3) Cause of bug: The variable $itemnumbers_of_biblioitem is declared but never used in reserve/request.pl which causes the Perl::Critic violation. Patch Description: This patch removes the variable $itemnumbers_of_biblioitem from reserve/request.pl in order to satisfy Perl::Critic. The variable $itemnumbers_of_biblioitem is never used anywhere in reserve/request.pl other than its declaration so it should not cause any undesired effects. Test Plan: 1) Drop into koha-shell and run the command 'prove t/00-testcritic.t'. 2) Test 221 fails. 3) Apply the patch. 4) Re-run 'prove t/00-testcritic.t'. 5) All of the tests pass now. 6) Quit out of koha-shell. Signed-off-by: Mark Tompsett <mtomp...@hotmail.com> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/