https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18356
Kyle M Hall <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Attachment #64021|0 |1 is obsolete| | Attachment #64022|0 |1 is obsolete| | Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Kyle M Hall <[email protected]> --- Created attachment 64310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64310&action=edit Bug 18356: Extend GetNextDate.t, add GetFictiveIssueNumber.t (unit=year) This patch deals with tests for yearly frequencies. Adjust/extend GetNextDate.t: [1] Adjust mixup of units/issues in a description. [2] Add testing +2 years on 29-2 of leap year for freq 1 issue/2 years. [3] Add tests for freq 9 issues/year. Add GetFictiveIssueNumber.t: [1] Two subtests are provided for irregular frequencies (very trivial) and for year frequencies (with four specific test cases). Test plan: [1] Run t/db_dependent/Serials/GetNextDate.t [2] Run t/db_dependent/Serials/GetFictiveIssueNumber.t Note: Without the second patch both tests should fail. This shows the need of the adjustments in the second patch. Signed-off-by: Marcel de Rooy <[email protected]> Signed-off-by: Josef Moravec <[email protected]> Signed-off-by: Kyle M Hall <[email protected]> --- Comment #13 from Kyle M Hall <[email protected]> --- Created attachment 64311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64311&action=edit Bug 18356: Fix date calculations for yearly frequencies in Serials The problem as described on BZ 18356 is a combination of an error in GetFictiveIssueNumber and GetNextDate for unit==year. [1] In GetNextDate the Add_Delta_YM calculation should be applied only to frequencies based on years per unit. In the case of multiple units per year we calculate the number of days to add. And if we have reached the end of a cycle, we correct the rounding applied in the cycle. NOTE 1: We obsolete the idea here of rebasing dates on firstacqui. In case of manual adjustments, we probably do not want it. And otherwise we do not need it anymore due to the correction at the end of a cycle. NOTE 2: The calls to Add_Delta_YM are intentionally not corrected for leap years. Say you start at 2016-02-29. If you use 1/yr or 1/2yr, you will switch to the Feb 28th in the following years. In 2020 there will be no switch to Feb 29 again; if someone should need it, please use a manual adjustment. This is probably highly exceptional. [2] In GetFictiveIssueNumber the year should be decreased by one if you have more units per year and you did not yet reach firstacqui day and month. This affects calculations in GetNextDate with irregularities. NOTE 1: I added a wrapper around Date::Calc::N_Delta_YMD in order to improve its results; this will especially be needed when we use it later for month units. NOTE 2: In case of manual adjustments this calculation does not really make sense. Another report should deal with improving irregularities. Test plan: [1] Verify that both GetNextDate.t as well as GetFictiveIssueNumber.t pass. [2] Look at the prediction pattern for a few frequencies. For example: 1 iss/y, 1 iss/2y, 5 iss/y. Signed-off-by: Marcel de Rooy <[email protected]> Signed-off-by: Josef Moravec <[email protected]> Signed-off-by: Kyle M Hall <[email protected]> --- Comment #14 from Jonathan Druart <[email protected]> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
