https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
DEVINIM <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #55 from DEVINIM <[email protected]> --- (In reply to Marcel de Rooy from comment #54) > (In reply to DEVINIM from comment #53) > > Created attachment 64490 [details] [review] [review] > > Bug 18651: [QA Follow-up] Fix the MAX(issue_id) calculation > > > > Found this by inserting the same issue_id in old_issues before checkin: > > The call to ->search( )->get_column is in scalar context and will > > return the number of results, i.e. always 1. > > If you have an issue_id 2 in old_issues, it will crash: > > DBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry '2' for key > > 'PRIMARY' > > > > The fix is fairly simple: Put get_column in list context and pick the first > > array entry. > > NOTE: Using DBIx's get_column()->max here might look simpler here. > > > > Signed-off-by: Marcel de Rooy <[email protected]> > > What's up, DEVINIM ? Hi Marcel, So sorry. How can I delete this attachment, I don't know. Can you tell me? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
