https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738
Kyle M Hall <k...@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62188|0 |1 is obsolete| | Attachment #62189|0 |1 is obsolete| | Attachment #62219|0 |1 is obsolete| | Marcel de Rooy <m.de.r...@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from Kyle M Hall <k...@bywatersolutions.com> --- Created attachment 64330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64330&action=edit Bug 17738: Replace GetReservesFromBorrowernumber with Koha::Patron->get_holds This patch replace the different calls to GetReservesFromBorrowernumber with a calls to Koha::Patron->get_holds. In some places we need to get a restricted set of holds, that's why we process a search on this holds returned by ->get_holds (on the found status for instance). The changes are quite trivial and reading the diff should be enough to catch bugs. Test plan: I would suggest to test this patch with patches from bug 17736 and bug 17737, to place different kind of holds (biblio and item level, future and past). Then do a whole workflow to detect bug, view a record, delete record, order, place a hold on an item which has been ordered, etc. The hold's informations should always be the same without or without these patches. Tested both patches together, works as expected. Signed-off-by: Marc Véron <ve...@veron.ch> Signed-off-by: Kyle M Hall <k...@bywatersolutions.com> --- Comment #15 from Kyle M Hall <k...@bywatersolutions.com> --- Created attachment 64331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64331&action=edit Bug 17738: Remove C4::Reserves::GetReservesFromBorrowernumber At this point, there should not be any occurrences of GetReservesFromBorrowernumber anymore. Signed-off-by: Marc Véron <ve...@veron.ch> Signed-off-by: Kyle M Hall <k...@bywatersolutions.com> --- Comment #16 from Kyle M Hall <k...@bywatersolutions.com> --- Created attachment 64332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64332&action=edit Bug 17738: Remove warning about redeclaration of $patron Signed-off-by: Marc Véron <ve...@veron.ch> Signed-off-by: Kyle M Hall <k...@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/