https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18785
Julian Maurice <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #3 from Julian Maurice <[email protected]> --- (In reply to M. Tompsett from comment #2) > There are a bunch of other bugzilla issues related to ->find and a scalar > context. > Perhapts actually using ->find({ biblionumber => $self->biblionumber }); or > I think others get lazy ->find( scalar $self->biblionumber )... or was it > return scalar Koha::Biblios->find($self->biblionumber); > Hmmm... anyways, this isn't right, as far as I can tell. I assume you are talking about bug 18179, but the patch I wrote doesn't make any call to 'find' in a list context. Plus, there is a check in Koha::Objects::find that prevents it to be used in a list context, so I think we're good. Callers of Koha::Subsbcription::biblio will be the ones to have to make sure it's called in scalar context. > Plus if it is singular, then why Biblios? This is the part I don't > understand in this and other code. The 'find' subroutine is defined in Koha::Objects, not Koha::Object. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
