https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066

--- Comment #5 from M. Tompsett <mtomp...@hotmail.com> ---
Comment on attachment 65771
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65771
Bug 19066 - Add branchcode to accountlines

Review of attachment 65771:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19066&attachment=65771)
-----------------------------------------------------------------

Looking for test that triggers "third" part of Circulation.pm changes.
prove t/db_dependent/Reserves/
prove t/db_dependent/Accounts.t
Just that one little change needs triggering before I'll sign off.
Read last Koha/Account comment, then first, then second.

::: C4/Circulation.pm
@@ +2872,3 @@
>      # Charge a new rental fee, if applicable?
>      my ( $charge, $type ) = GetIssuingCharges( $itemnumber, $borrowernumber 
> );
>      if ( $charge > 0 ) {

Do we have a test that triggers this? I haven't found it yet.

::: Koha/Account.pm
@@ +69,5 @@
>      my $lines           = $params->{lines};
>      my $type            = $params->{type} || 'payment';
> +    my $branchcode      = $params->{branchcode};
> +
> +    $library_id ||= C4::Context->userenv ? C4::Context->userenv->{'branch'} 
> : undef;

But why line 73 and change the line?

@@ +74,2 @@
>  
>      my $userenv = C4::Context->userenv;

Why not just after $userenv here, and keep the line identical?

@@ -194,5 @@
>              note              => $note,
>          }
>      )->store();
>  
> -    $library_id ||= $userenv ? $userenv->{'branch'} : undef;

Yes, this needs to move.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to