https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19119
Bug ID: 19119
Summary: Remove t/db_dependent/api/v1/swagger/definitions.t
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Test Suite
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
While it might have seemed a good idea to have such a test, I find it useless
as-is, because there's no obvious reason why we would expose our model on the
API spec while it is just user-facing and not a technical explanation on how we
do things inside our codebase.
A good example of this could be bug 18120, in which it is obvious that some
attribute names are misleading or the attributes themselves need to be stripped
out of the object for exposing on the API.
There can be ways of doing this two operations (i.e. removing/adding
attributes, and renaming) without handling it on the controller as those
patches do. But in any case, there's no need for definitions.t.
We could have a gentle 'warning' in the QA tools in case of a column being
added to the DB structure and not to the corresponding endpoint, but it has to
be a soft requirement IMO.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
