https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002
--- Comment #49 from Katrin Fischer <[email protected]> --- Not sure if this one is valid, but the QA tools get upset about missing POD: FAIL C4/Budgets.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD is missing for GetHighestBudgetPeriod OK spelling OK valid Some small stuff from code review: 1) We should not have unconditional warns: Budgets.pm + warn my $data = $dbh->selectrow_array("SELECT MAX(budget_period_id) FROM aqbudgetperiods"); 2) Small typo here: <p>Start by completing this form to create a currency which <strike>you</strike> will be used to create your first budget and fund.<br> 3) Wrong link to the manual - always use http://koha-community... now. <p>Start by completing this form to create a currency which you will be used to create your first budget and fund.<br> 4) Why do you comment out the hint? And why only on one of the 2 date fields? +<!--<div class="hint">[% INCLUDE 'date-format.inc' %]</div>--> 5) Please include current test plans in commit message - otherwise it's often hard to spot the right one and it will help people looking at git later. :) 6) Some little spelling things: Vendor Information page = vendor information page according to our capitalization rules. Also budget administration page etc. Some more from testing, overall the feature works alright and is a nice addition. I am mostly concerned about the next point: 6) Wondering: Is there no way to skip the Onboarding process from the installer? Or the Acquisitions onboarding? People who have done this a lot of times before might want to skip the process. Because you want to add more currencies at the same time, add your whole fund structure etc. I would like it better if it was visible, but less invasive maybe? Also: Some libraries never set up acq, but need to be able to manage vendors in acquisitions. So it might be nice if the onboarding tool could be hidden if not needed. Some ideas: - Don't show the onboarding tool if the user has only vendor_manage permission. - Only show the onboarding tool, if the user has full acq permissions or is a superlibrarian. - I am not sure how helpful the 'next steps' are. Maybe they would be better suited to go into the manual or help file? As it is the bug button always remains visible, even if you are a power user of acq. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
