https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060

Katrin Fischer <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |[email protected]

--- Comment #16 from Katrin Fischer <[email protected]> ---
Hi Alex, applied this on top of 18002.

QA tools first:

 FAIL   C4/Creators/Layout.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   FAIL   pod coverage
                POD is missing for 'retrieve_all'
   OK     spelling
   OK     valid

 FAIL   C4/Creators/Profile.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   FAIL   pod coverage
                POD is missing for 'retrieve_all'
   OK     spelling
   OK     valid

 FAIL   C4/Creators/Template.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   FAIL   pod coverage
                POD is missing for get_next_label_pos
                POD is missing for retrieve_all
   OK     spelling
   OK     valid

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt
   OK     forbidden patterns
   OK     git manipulation
   FAIL   spelling
                 seperate  ==> separate
   OK     tt_valid
   OK     valid_template

Other files came back all green.

Code review: didn't spot anything.

Testing:
When I try to access Tools > Label Creator I get an "internal server error". In
the plack logs this translates to:
Variable "$layout" is not available at
/home/vagrant/kohaclone/labels/label-home.pl line 56.
Can't call method "get_attr" on an undefined value at
/home/vagrant/kohaclone/labels/label-home.pl line 56.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to