https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14850

M. Tompsett <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
             Status|Needs Signoff               |Failed QA

--- Comment #5 from M. Tompsett <[email protected]> ---
Not a hard fail.

Missing License.
https://wiki.koha-community.org/wiki/Coding_Guidelines#Licence

Budget.pm is not perl tidy.
https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL1:_Perltidy


> push @budgets_loop, \%$line;

Isn't this the same as $line? You already treat $line as a hash ref in the
previous line code change. Haven't tested just read it and thinking out loud.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to