https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747
Marcel de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #48 from Marcel de Rooy <[email protected]> --- QA Comment: Thx for your proposal. Some points that need attention: Breeding.pm: @servers = (); foreach my $id (@id) { push @servers, {id => $id}; } Please explain what you are doing here. Seems unneeded or wrong. $template->param( additionalFields => '1' ) if C4::Context->preference('AdditionalFieldsInZ3950ResultSearch'); Please use Koha::Preference in the template. sub _add_rowdata Just intuitive, these additions dont look that nice to me. I think you should add more validation and put this in another subroutine, taking care that you do not overwrite the default fields. +++ b/installer/data/mysql/atomicupdate/bug_12747-additional_fields_in_Z3950_search_result.sql @@ -0,0 +1 @@ +INSERT INTO systempreferences Please INSERT IGNORE +('AddressFormat','us','','Choose format to display postal addresses', 'Choice'), +('AdditionalFieldsInZ3950ResultSearch', '', NULL, 'Determines which MARC field/subfields are displayed in -Additional field- column in the result of a search Z3950', 'Free'), Please respect the sort order in sysprefs. Note: I saw that a LOT of other new prefs are not in the right order. But you dont need to correct that here of course. Just add your own one in the right place. + [% IF additionalFields %] + <td> + <dl> + [% FOREACH addnumberfield IN breeding_loo.addnumberfields %] + <dt>[% addnumberfield %]:</dt> + <dd>[% breeding_loo.$addnumberfield %]</dd> + [% END %] + </dl> + </td> + [% END %] You add all additional fields in one column?? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
