https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385
Marcel de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Marcel de Rooy <[email protected]> --- QA Comment: Thanks for your work. I think this is not yet ready for inclusion. sub XSLTParse4Display { - my ( $biblionumber, $orig_record, $xslsyspref, $fixamps, $hidden_items, $sysxml, $xslfilename, $lang ) = @_; + my ( $biblionumber, $orig_record, $xslsyspref, $fixamps, $hidden_items, $sysxml, $xslfilename, $lang, $xslFile, $opac ) = @_; We already have $xslfilename. You add $xslFile ? Does not look good. The added code seems repetitive. You add a new routine CustomXSLTExportList. It needs unit tests. In that routine you are parsing the xsl files for something like +<!-- xml title="Simple Export" -->. I am not sure if that is a good idea. Another QA pov is welcome too. Note that you are doing it each time again too. If you provide clear xslt names, that should probably be sufficient. Please think about another way to enrich that information if needed. --- a/Koha/XSLT_Handler.pm +++ b/Koha/XSLT_Handler.pm @@ -168,7 +168,6 @@ sub transform { ( $xml, $filename, $format ) = @_; $format ||= 'chars'; } - #Initialized yet? if ( !$self->{xslt_hash} ) { $self->_init; No need to remove an empty line if you are not touching this module anyway. diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/biblioexport/README b/koha-tmpl/intranet-tmpl/prog/en/xslt/biblioexport/README new file mode 100644 Empty README ? And another further on. koha-tmpl/opac-tmpl/bootstrap/en/xslt/biblioexport-samples/MARC21_simple_export.xsl koha-tmpl/opac-tmpl/bootstrap/en/xslt/biblioexport/MARC21_simple_export.xsl What is the use of adding two identical files here ? Actually, all files here are sort of sample files. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
