https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18149
--- Comment #6 from Marcel de Rooy <[email protected]> --- (In reply to Tomás Cohen Arazi from comment #5) > (In reply to Marcel de Rooy from comment #4) > > (In reply to Tomás Cohen Arazi from comment #3) > > > Marcel, I agree with the removal, but you seem to be fixing a bug in the > > > meantime (which I'm not against per-se) but I think if falls short, as we > > > should be warning or similar about those non-existing authority records. > > > > This is about two checks? > > [1] opac-authoritiesdetail > > -my $authtypecode = $authority->authtypecode; > > +my $authtypecode = $authority ? $authority->authtypecode : q{}; > > This does not fall short. It actually is only theoretical. If GetAuthority > > fails, the script redirects to 404. > > > > [2] authorities/detail.pl > > -my $authtypecode = Koha::Authorities->find($authid)->authtypecode; > > +my $authobj = Koha::Authorities->find($authid); > > +my $authtypecode = $authobj ? $authobj->authtypecode: q{}; > > Similar here. This check just prevents an ISE on authtypecode while a few > > lines later the output of GetAuthority is checked and an error is printed > > via the template. So no, it does not fall short. > > > > Please explain why this fails QA. > > It is not a big deal, I just would like the script to warn (in the logs) in > addition to the fallback to empty string. We do not need these warns. As mentioned, the script either redirects to 404 or prints an error already. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
