https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438
Marcel de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #43 from Marcel de Rooy <[email protected]> --- QA Comment: Looks good to me apart from a few minor comments (see above). Just noting: When the checkout fails, SIP returns a VALID_PATRON response BL=Y. It does not when the checkout is ok. The due date passed in the sip request is simply ignored. If I pass an old date or even an invalid date, the item is still checked out. Opened bug 19276 for error in CanBookBeIssued re statistical patrons. We could perhaps use a unit test that helps us 'force' a policy somehow about the lowercase/uppercase returns from CanBookBeIssued. We are still missing a checkout test in t/db/SIP/Message. No time to write it here. In view of the age of this patch and the attention already given by several people before me, I am passing QA on this patch now too. (The last comment of Kyle could be read as a kind of signoff too btw.) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
