https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602
--- Comment #39 from Tomás Cohen Arazi <[email protected]> --- Ok, I tested this patchset and have some comments. I used the credentials ByWater provided, with a logged-in user with Nick's email address set as primary (which is recognized as valid for the RecordedBooks credentials). From the functional perspective, everything works as expected: * Searches * Checkout * Checkin * Holds I would only try to make the UI tell the users it is working on something and prevent them from (re)clicking other RecordedBooks buttons (spinning symbol or similar). Not worth failing the patchset because of it, but definitely a needed followup. Regarding the whole patchset, I'd say tests coverage is not good enough. And having the tests require valid credentials for the proprietary external system seems too much. There are two options IMHO: - If the provider does have a sandbox/testbed infrastructure, use it - If it doesn't, keep the tests (which skip if credentials are missing) but add new db-independent tests with mocked behaviour for WebService::ILS. Auth_with_ldap.t can be a good source of examples for completely mocking the tests. I'm looking forward to help having this in 17.11, so don't hesitate to contact me for quick feedback. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
