http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5337
Paul Poulain <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #23 from Paul Poulain <[email protected]> --- QA comment: * this patch removes EAN search for MARC21, good point * it uses [% UNLESS (MARC21) %] => bad point. If you set NORMARC, you'll get the ean option. The general rule is, when something is specific to UNIMARC, to do "IF UNIMARC" and not "UNLESS MARC21" ! * it would be good to add a marc_subfield_structure when updating: + if (C4::Context->preference("marcflavour") eq 'UNIMARC') { + $dbh->do("UPDATE marc_subfield_structure SET kohafield='biblioitems.ean' WHERE tagfield='073' and tagsubfield='a'"); + } (just after the add column and index) * in opac-detail, there is a repeated my $marcflavour = ...; remove the one at line 390 I think -my $marcflavour = C4::Context->preference("marcflavour"); (this makes perl -wc complain) failed QA, once it's fixed, i'll mark passed QA I think, everything else is OK -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
