https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18399
--- Comment #11 from Alex Arnaud <alex.arn...@biblibre.com> --- (In reply to Nick Clemens from comment #10) > Hi Alex, > > Why not use Koha::Template::Plugin::AuthorisedValues rather than processing > the category in the pl and passing it? GetAuthorisedValues("SUGGEST") was already there in the pl. I just moved it to make it available everywhere. Also i need these authorised values to check if a suggestion has a common or other reason before displaying it. I think this peace of code is more easily "writable" in the pl than in the template. > > $(this).next("#other_reason").show(); > should be the same as > $("#other_reason").show(); Right! > > I like the way the 'Other' suggestions work but 'Cancel' is a confusing > wording (if I am editing an existing suggestion I am not 'cancelling' but > 'changing') I would suggest 'Choose an standard value' or something similar I totaly agree that the word is not relevant (i wondered the same while making the patch). But i thought the best was to keep consitency between the 2 pages (list of suggestions / editing one suggestion). Right? > > Nice and needed feature. > > -Nick -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/