https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486
Tomás Cohen Arazi <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #24 from Tomás Cohen Arazi <[email protected]> --- (In reply to Katrin Fischer from comment #17) > 1) Translations in mind, I suggest to make the message a bit more specific: > Daily limit reached for patron > > Daily hold limit reached for patron Fixed, thanks! > 2) If nothing is entered, it appears to default to 0 (instead of unlimited). > So I think this will break existing installations. I'd suggest to copy the > max holds total into max holds daily. This is intended, on purpose! Its the same behaviour allowedreserves has. 0 and undef mean the same in the code. If no daily (or zero) limit is defined, then the global one is used > 3) The tests are giving me trouble: > kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Holds.t > t/db_dependent/Holds.t .. 26/59 # Looks like you planned 59 tests but ran 56. > t/db_dependent/Holds.t .. Dubious, test returned 255 (wstat 65280, 0xff00) > Failed 3/59 subtests Fixed it, I guess some recent changes in Holds.t made this. Tests should pass noW! Thanks for the feedback! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
