https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747
--- Comment #56 from M. Tompsett <[email protected]> --- Comment on attachment 67314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67314 Bug 12747 - Corrections on QA feedback Review of attachment 67314: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12747&attachment=67314) ----------------------------------------------------------------- ::: C4/Breeding.pm @@ -224,5 @@ > - @servers = (); > - foreach my $id (@id) { > - push @servers, {id => $id}; > - } > - Why was this removed? Did you add it before? @@ +344,5 @@ > + > + return $row; > +} > + > +sub _add_custom_field_rowdata Nice extraction. ::: installer/data/mysql/sysprefs.sql @@ +9,2 @@ > ('AdditionalFieldsInZ3950ResultSearch', '', NULL, 'Determines which MARC > field/subfields are displayed in -Additional field- column in the result of a > search Z3950', 'Free'), > +('AddressFormat','us','us|de|fr','Choose format to display postal > addresses', 'Choice'), Intermediate patches dealing with rebases makes this look like a mistake. Squashing is frequently a good idea where possible. ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt @@ +133,4 @@ > <th>Author</th> > <th>ISBN</th> > <th>LCCN</th> > + [% IF Koha.Preference('AdditionalFieldsInZ3950ResultSearch') != '' %] Length, != ''... okay, this is better. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
