https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19431
--- Comment #13 from Marcel de Rooy <[email protected]> --- (In reply to Jonathan Druart from comment #12) > (In reply to Marcel de Rooy from comment #11) > > - unless( $onsite_checkout and > > C4::Context->preference("OnSiteCheckoutsForce") ) { > > + if ( $error->{UNKNOWN_BARCODE} or not $onsite_checkout or not > > C4::Context->preference("OnSiteCheckoutsForce") ) { > > > > If CanBookBeIssued sets the UNKNOWN_BARCODE flag, it returns no DEBT > > question and no other impossible errors. But since there is one error, it > > will set $blocker to 1. > > Just wondering if there are other errors that should trigger the blocker > > flag when doing onsite checkouts here. If CanBookBeIssued said No, when is > > an onsite checkout still possible? > > I put the test there to avoid to copy paste the blocker=1 and the IMPOSSIBLE > flag. Do you have something better to suggest? My question was: Is UNKNOWN_BARCODE the only one needed here? Should the blocker flag be set (among other things) for other types of errors ? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
