https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18153
M. Tompsett <mtomp...@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtomp...@hotmail.com Status|Needs Signoff |In Discussion --- Comment #15 from M. Tompsett <mtomp...@hotmail.com> --- (In reply to Julian Maurice from comment #12) > 1. With the patch, the export tool also modifies the leader of exported > authorities (position 9 is for authority type, so this is a problem) > 2. The code is poorly formatted and is missing a comment to explain why we > need to do this. The new patch seems to address this, but I haven't tested it yet. > 3. It only fixes exported records from the export tool and only for iso2709 > format. If I export in marcxml or if I use the 'Save' button from the detail > page, the leader is still invalid. I think this is a valid reason to keep it Failed QA, though I'm changing it to in discussion. The summary doesn't say only iso2709 export format. It suggests UNIMARC records in general. > 4. This patch states clearly that the leader may be invalid in Koha but > tries to fix it at export-time instead of fixing it directly in Koha. I > think it is possible to fix the leader at save-time, so that every biblio > created/modified (whether it's by import or manually) will be saved with a > correct leader. And maybe at read-time too, for already existing invalid > records. @QAers, any opinions ? While I am not a QA person, I think this is a really good point. The leader record should be saved correctly in the first place, not need correction on export. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/