https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #9 from Kyle M Hall <[email protected]> --- (In reply to Tomás Cohen Arazi from comment #8) > Kyle, I'm failing it so it is obvious that some changes are needed for its > inclusion! > > (In reply to Jonathan Druart from comment #7) > > Readonly: see bug 16588 > > We are trying explicitly to get rid of Readonly, dicussion on that bug. Will fix! > > Koha::Patrons->merge: See 15336, it adds a > > Koha::Acquisition::Bookseller->merge_with #consistency > > Self explanatory! This one isn't so easy for me ; ) Bookseller->merge_with is a method for a single object, and acts upon it. Koha::Patrons->merge is a method that accepts a patron, and a list of patrons to merge into. I think it's actually better because the parameters make is clear which patron will be retained. With Bookseller->merge, I cannot tell which Bookseller will be removed and which will be kept without reading the code. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
