https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17214

--- Comment #22 from Marcel de Rooy <[email protected]> ---
QA Comment:
No blocker, but having some doubts on this line:
if ($@) {
    push @messages, { bibnum => $biblionumber, type => 'alert', code =>
ref($@), msg => $@ };

For a regular die ref($@) is empty string, so code will be empty. 
If $@ is an object, the template only checks DBIx::Class::Exception.
But shelf store might raise a few Koha::Exceptions too..
Added a follow-up that at least adds message when code is empty.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to