https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243
M. Tompsett <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #19 from M. Tompsett <[email protected]> --- (In reply to Jonathan Druart from comment #15) > Alex, some remarks: > 1. take a look at basic_workflow.t, there are some changes you did not take > into account (19337) > 2. Tests must create the data they need and delete them. Here you are using > the FA framework and modify it. That means the tests will fail if executed > twice. > 3. The cleanup method is wrong, it should not be a method as the different > selenium test files will have different a cleanup. > 4. t::lib::Selenium::pause_driver does not work as you would like? I didn't look to see if the code actually address points 2-4. I believe my patches deal with 1. I'm going to set this to Failed QA, even though the tests ran successfully. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
