https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915
--- Comment #8 from M. Tompsett <[email protected]> --- Comment on attachment 66518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66518 Bug 18915: Fix checkout note email message Review of attachment 66518: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18915&attachment=66518) ----------------------------------------------------------------- ::: installer/data/mysql/updatedatabase.pl @@ +14308,4 @@ > > $dbh->do(q| > INSERT IGNORE INTO letter (`module`, `code`, `branchcode`, `name`, > `is_html`, `title`, `content`, `message_transport_type`) > + VALUES ('circulation', 'CHECKOUT_NOTE', '', 'Checkout note on item > set by patron', '0', 'Checkout note', '<<borrowers.firstname>> > <<borrowers.surname>> has added a note to the item <<biblio.title>> - > <<biblio.author>> (<<biblio.biblionumber>>).','email'); I don't think updatedatabase should be modified like this. This is already done. You add a new DB update which tweaks PATRON_NOTE into CHECKOUT_NOTE, if this is correct logic. ::: opac/svc/patron_notes @@ +82,4 @@ > my $biblionumber = $issue->item->biblionumber; > my $letter = C4::Letters::GetPreparedLetter ( > module => 'circulation', > + letter_code => 'CHECKOUT_NOTE', Why even change the letter code, given that you aren't changing the svc name? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
