https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18458
Marcel de Rooy <m.de.r...@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Marcel de Rooy <m.de.r...@rijksmuseum.nl> --- Janusz, Thx again for this patch. I am not so sure though if your code really makes sub merge easier (it is hard enough already). Couldnt we do the following in order to keep the order intact: Copy all fields in original order including $9. Overwrite the authority controlled fields. If $overwrite, delete a subfield that is not controlled (only skip $9). [A hypothetical question: what about repeated subfields?] Update $9 finally. Another thing: - append_fields_ordered( $marcrecord, $field_to ); + $marcrecord->insert_fields_ordered($field_to); This is a regression. Look at the comments in append_fields_ordered. You change the order of fields here. Finally, we need some tests to support your changes. Have a look at t/db_dependent/Authority/Merge.t :) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/