https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938
--- Comment #16 from Julian Maurice <julian.maur...@biblibre.com> --- (In reply to M. Tompsett from comment #15) > It seemed from comment #11 and comment #12, that the FailedQA was for the > git commit messages, not the actual code. > > Changing the return value and tweaking code based on that is a refactor, > just not in a huge rewrite from scratch sense. Perhaps there is a better > word, but I can't think of it right now. According to Wikipedia, > Code refactoring is the process of restructuring existing computer code > without changing its external behavior. IMO the return value is part of the external behavior of a subroutine, so it's not a refactor. But I won't block this any longer for such a minor issue. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
