https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995
--- Comment #27 from M. Tompsett <[email protected]> --- I understand the desire to single file each exception. That makes sense. We can use directory structure to sort them if needed. git bz apply 13995 git diff origin/master | grep "package Koha::Exception::" | sed -e "s#\+package ##g" | sed -e "s#;##g" > ~/new_exceptions git grep "'Koha::Exceptions::" | grep -v "isa\W*=" | grep ^Koha/Exceptions | cut -f2- -d: | sed -e "s#[=>{ ']*##g" > ~/existing_exceptions Looking at new and existing exceptions, we see that there may be some overlap and as Tomás Cohen Arazi pointed out in comment #26, there is likely a need for better consolidation and sorting. So even if I wanted to sign this off, there is still clean up to do here. For this reason, I am leaving it Failed QA. I would be willing to sign off if this: 1) duplicates all the exceptions in Koha/Exceptions 2) would refactor nicely such another bug would merely remove the 's' from Exceptions 3) has test coverage for all the exception files -- if 1 & 2 are met, I'd be happy to write the test coverage just to get sign offs moved forward. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
