https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769
--- Comment #33 from Julian Maurice <julian.maur...@biblibre.com> --- Patches work as expected. I signed off the patches but I think another sign-off from a MARC21 expert would be great. A few comments on the code: - I think that the subroutine controlled_indicators doesn't belong in Koha::Authority. The FIXME added in C4::AuthoritiesMarc strengthens that opinion - In Koha::Authority::ControlledIndicators, there is a package variable $cached_indicators. Maybe this module should use Koha::Cache instead ? Also, I'm not sure if this is a problem, but it seems that there is no way to tell Koha to change only one of the two indicators. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
