https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818
Victor Grousset/tuxayo <victor.grous...@biblibre.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |In Discussion
CC| |victor.grous...@biblibre.co
| |m
--- Comment #7 from Victor Grousset/tuxayo <victor.grous...@biblibre.com> ---
Hi, after discussing with delaye, can I add a patch with following changes?
(except if for {learning, fun, wanting this bug to be finished quickly} reasons
someone else wants to do it)
1. Change some of the new ids, e.g. #surname → #alt-contact-surname
To add more semantic and avoid id collisions.
Mosty in #patron-alternative-contact
2. #borrowernumber → #library-use-borrowernumber
#borrowernumber is already used in «Upload patron image»
3. #zip/postalcode → #zip-postal-code
/ are valid in HTML but will be a pain when using selectors in CSS or
JavaScript
https://stackoverflow.com/questions/27255591/using-forward-slash-as-id-attribute#27256827
4. In #patron-alternate-address add ids, this section was forgotten.
The trap was that me must fill all the field when editing the patron to
ensure that they are displayed in the profile.
5. Add ids to the <li>s of #patron-information
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
