https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #36 from Jonathan Druart <[email protected]> --- (In reply to Marcel de Rooy from comment #35) > [1] With reference to above comments: > >> Furthermore I would expect to have max_holds also under Default checkout, > >> hold and return policy. It seems consistent to add it also without a patron > >> category restriction. > > > That behavior is controlled by the maxreserves system preference. We should > > move that out of a syspref and into the circ rules. I'd be happy to do that > > on another bug but it's definitely out of the scope of this bug. > > Yes, sir. Please remove maxreserves on a new report. Note that you already > added code for that by putting max_holds in default_circ_rules. At this > moment it is actually not used by the interface. > > [2] See my earlier comment about introducing new DBIx constructions. No > blocker for now, but imo we should add a coding guideline. About 1 & 2: And I think that is what is wrong here. We should have default_circ_rules.max_holds on the interface, then call GetBranchBorrowerCircRule from CanItemBeReserved It sounds like a trivial change and so I think it should be added by this patch set. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
