https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289
--- Comment #25 from Jonathan Druart <[email protected]> --- (In reply to Katrin Fischer from comment #24) > Hi Jonathan, > > continuing here. Could you please rebase? Will do. > (In reply to Jonathan Druart from comment #23) > > (In reply to Katrin Fischer from comment #22) > > > QA tools pass. > > > > > > Some first notes from reading the code: > > > > > > 1) > > > installer/data/mysql/en/marcflavour/marc21/mandatory/ > > > marc21_framework_DEFAULT.sql > > > > > > It looks like the code makes some assumptions about > > > biblioitems.publicationyear. There is something you will not like about > > > this > > > field: It's only used by UNIMARC by default. MARC21 installations safe > > > that > > > information to biblio.copyrightdate. Both use cases need to be supported. > > > > It is the current behaviour, neworderempty.tt displays > > biblioitems.publicationyear. > > If it is an existing bug it needs to be fixed on a separate bug report. > > I have thought about this some and I think for MARC21 just replace > publicationyear with copyrightdate. The problem is: it will create on > mapping. There is no field mapped to publicationyear in a MARC21 > installation so the SQL will do nothing as it is on a MARC21 installation > most likely. If you change it to copyrightyear the field will be filled as > it's in the other frameworks and we will only have to deal with a display > problem. Ideal would probably be check what exists in the frameworks you are > pulling from and use that. I am not sure I understand the problem neither the solution, but I have tried and provided a patch. Let me know if it is what you had in mind. > > > 3) Atomicupdate doesn't include changes for creating the ACQ framework. > > > > ACQ framework was added by bug 3841 for new installation. I do not think we > > should deal with existing installation (what about those having already the > > framework?) > > On my installation that meant after activating the rule I had an empty > framework. The ACQ framework was only created with 952, so no fields the > record itself. Giving a more complete sample with the most important fields > would be good as entering this data is very annoying. At the moment an acq > record is created with the default framework - will it be ACQ now? Couldn't > test because of the conflicts. I am a bit worried people will forget to add > important fields like the leader (causes problems with encoding), 999 > (causing problems at indexing) and others. ACQ is only use for display purpose here, so no need to add fields we do not want to see. > > > 3) koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt > > > A lot of FIXMEs in this code? > > > > It is to highlight the fact that the default values defined in ACQ will not > > be taken into account. I can remove it if you think it is confusing > > As some code editors let you highlight strings like FIXME I think we should > not use if it's not a real FIXME maybe. Why will the default not be used? > Are there other limits (plugins?) No, nothing else is used, no default, no plugin, etc. We display a dropdown list if linked with a authorised value list and make the field mandatory if marked as it in the framework. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
