https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #5 from Josef Moravec <josef.mora...@gmail.com> --- Comment on attachment 72300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72300 Bug 20271: merging delete biblio/items Review of attachment 72300: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20271&attachment=72300) ----------------------------------------------------------------- Just a quick look: there is missing atomic database update also the test suite should be adjusted I am not sure about the changes in OAI, so need to investigate more later ::: C4/Biblio.pm @@ -3182,5 @@ > - my $bkup_sth = $dbh->prepare($query); > - $bkup_sth->execute(@bind); > - $bkup_sth->finish; > - > - _koha_delete_biblio_metadata( $biblionumber ); this is missing in your patch ::: C4/Items.pm @@ +1061,4 @@ > FROM items > LEFT JOIN branches AS holding ON items.holdingbranch = > holding.branchcode > LEFT JOIN branches AS home ON items.homebranch=home.branchcode > + LEFT JOIN biblio ON biblio.biblionumber = > items.biblionumber AND biblio.deleted_at IS NULL I don't think this will work, that's condition should be in where clause ::: misc/export_records.pl @@ +105,5 @@ > push @record_ids, $_->{biblionumber} for @{ > + $dbh->selectall_arrayref(q| > + SELECT biblionumber > + FROM biblioitems > + |, { Slice => {} }, ( $timestamp ) x 4 ); Please include the changes made by Bug 19730 -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/