https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570
--- Comment #11 from Katrin Fischer <katrin.fisc...@bsz-bw.de> --- (In reply to M. Tompsett from comment #10) > Failed QA for one major reason: Missing test coverage. > > Do not modify C4 or Koha libraries without including tests. > Also, because I think it is the wrong way to do it, but test coverage either > way. Hi Mark, if you think it's the wrong way to do it, please explain. It makes no sense to write tests when the idea of the patch needs to be changed later on. I was thinking the routine might be better not so single purpose. I think there might be other use cases like the patron registration verification emails (I even think there is a bug about those already) that we will want to send immediately. I Maybe just needs the letter code as parameter and a more general name? Could there be a scenario where we have a race condition? Entry not yet written to message_queue and tryint to send it or similar? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
