Maksim Sen <> changed:

           What    |Removed                     |Added
  Attachment #68214|0                           |1
        is obsolete|                            |

--- Comment #64 from Maksim Sen <> ---
Created attachment 72706
Bug 12747 - Add extra column in Z3950 search

This is a complete squash of previous patches, with additional code quality
improvments following M. Tompsett's feedback. Squashing was done (as suggested)
because many lines add be added and subsequently deleted, which made for
confusing patches.

New changes:
* Major enhancement to _add_custom_rowdata(), as suggested by QA. The $_
variable is no longer used (at all), and the split() routine is used.
* t/db_dependent/Breeding.t now uses the mocked preference logic to avoid
sysprefs being affected.

Functionality and test plan have not changed.


This patch makes it possible to add an extra column to Z3950 search results.
The system preference AdditionalFieldsInZ3950ResultSearch maps which MARC
field/subfields are displayed in the column.


I Apply the patch
II Run

0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch
1) Create a new basket or use an existing one
2) In -Add order to basket-, click "From an external source"
3) Select some search targets and enter a subject heading ex. house
4) Click Search bouton
5) Validate "Additional fields" column with the field/subfield value.

0) Shares same syspref as above
1) Go to cataloguing, click New from z3950
2) Fill to result in a successful search
3) Validate column Addition Fields

Sponsored-by: CCSR (

You are receiving this mail because:
You are watching all bug changes.
Koha-bugs mailing list
website :
git :
bugs :

Reply via email to