https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20444

--- Comment #5 from M. Tompsett <[email protected]> ---
Comment on attachment 73083
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73083
Bug 20444: Use Koha::Patron::Attribute::Types object for getting patron
attributes in letter.pl

Review of attachment 73083:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20444&attachment=73083)
-----------------------------------------------------------------

::: tools/letter.pl
@@ +463,4 @@
>          }
>      }
>      if ($table eq 'borrowers') {
> +        my $attribute_types = Koha::Patron::Attribute::Types->search;

This let's you loop like an array, but it isn't ordered by code as far as I can
tell. Feel free to correct me. Does this need to be code equivalent? Or just
similar functionally?

@@ -462,4 @@
>          }
>      }
>      if ($table eq 'borrowers') {
> -        if ( my $attributes = C4::Members::Attributes::GetAttributes() ) {

This is a sorted array of codes...

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to