https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446
--- Comment #26 from Tomás Cohen Arazi <tomasco...@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #25) > (In reply to Jonathan Druart from comment #22) > > It's more about consistency: AcqCreateItem pref's value should not be > > retrieved directly, the logic should be stay in Koha::Acquisition::Basket > > Both solutions do the job, but given the fact we have an encapsulated > business-logic behind 'effective_create_item', the best way to do it is to > use the encapsulated one, because any changes on that business logic or > (new?) pref combinations wouldn't have an impact on the EDI code itself. Its a pity I'm not seeing regression tests for this btw. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
